Mailman 3 December 2002 - Mailman-Developers

[ mailman-Patches-645422 ] $prefix hardcoded in qmail-to-mailman.py
by noreply＠sourceforge.net 24 Dec '02

24 Dec '02

Patches item #645422, was opened at 2002-11-28 15:52 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=645422&group_i… Category: mail delivery Group: Mailman 2.1 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Matthias Juchem (brightice) Assigned to: Nobody/Anonymous (nobody) Summary: $prefix hardcoded in qmail-to-mailman.py Initial Comment: This patch replaces the hardcoded $prefix in contrib/qmail-to-mailman.py with @prefix@, which is replaced with $prefix during configure. Tested, works for me. ---------------------------------------------------------------------- Comment By: Matthias Juchem (brightice) Date: 2002-12-08 19:29 Message: Logged In: YES user_id=60479 Stupid me, patch is for 2.1, not for 2.2/3.0. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=645422&group_i…

1 0

[ mailman-Patches-645431 ] Filter spam on message body
by noreply＠sourceforge.net 24 Dec '02

24 Dec '02

Patches item #645431, was opened at 2002-11-28 16:20 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=645431&group_i… Category: list administration >Group: Mailman 2.2 / 3.0 Status: Open Resolution: None Priority: 5 Submitted By: anser (anser) Assigned to: Nobody/Anonymous (nobody) Summary: Filter spam on message body Initial Comment: This patch adds a matching spam check for body content. It works exactly like the header check, except the message body (after base64/quoted-printable decoding) is scanned. You will need to remove and re-add any lists that you want to use this feature on after installing it. Make sure you get a new Defaults.py as well. The patch is pretty clean. ---------------------------------------------------------------------- >Comment By: Barry A. Warsaw (bwarsaw) Date: 2002-12-23 22:23 Message: Logged In: YES user_id=12800 Because this is a new feature, I have to defer it until after MM2.1 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=645431&group_i…

1 0

[ mailman-Patches-651406 ] MM 2.0.13 to 2.1b5 upgrade fails
by noreply＠sourceforge.net 24 Dec '02

24 Dec '02

Patches item #651406, was opened at 2002-12-10 07:38 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=651406&group_i… Category: None Group: Mailman 2.1 >Status: Closed Resolution: None Priority: 5 Submitted By: Richard Barrett (ppsys) Assigned to: Nobody/Anonymous (nobody) Summary: MM 2.0.13 to 2.1b5 upgrade fails Initial Comment: make install when updating a MM 2.0.13 installation to 2.1b5 initally produced the following exception: Updating mailing list: mailman Traceback (most recent call last): File "bin/update", line 569, in ? errors = main() File "bin/update", line 446, in main errors = errors + dolist(listname) File "bin/update", line 186, in dolist mlist = MailList.MailList(listname, lock=0) File "/mailman/run/Mailman/MailList.py", line 101, in __init__ self.Load() File "/mailman/run/Mailman/MailList.py", line 600, in Load self.CheckValues() File "/mailman/run/Mailman/MailList.py", line 650, in CheckValues for name, pattern, desc, emptyflag in self.topics: File "/mailman/run/Mailman/MailList.py", line 130, in __getattr__ raise AttributeError, name AttributeError: topics make: *** [update] Error 1 Having corrected the cause of this first exception the following exception was then encountered: Upgrading from version 0x2000df0 to 0x20100b5 getting rid of old source files Updating mailing list: mailman Traceback (most recent call last): File "bin/update", line 569, in ? errors = main() File "bin/update", line 446, in main errors = errors + dolist(listname) File "bin/update", line 200, in dolist for addr, (reason, when) in mlist.delivery_status.items (): File "/mailman/run/Mailman/MailList.py", line 130, in __getattr__ raise AttributeError, name AttributeError: delivery_status make: *** [update] Error 1 These problems both seem to arise because of the following: 1. The MailList class is derived from the classes TopicMgr and Bouncer (amongst others). 2. The MailList __init__ function calls the __init__ functions of its superclasses if they have that function; which they do not in the case of the of TopicMgr and Bouncer classes 3. The MailList __init__ function calls its own InitTempVars function which in turn calls the InitTempVars functions of MailList's superclasses if they have that function; which they do not in the case of the of class TopicMgr and Bouncer classes 4. The MailList __init__ function does not call the InitVars functions of the TopicMgr and Bouncer classes which is why self.topics and self.delivery_status are undefined attributes of the MailList instance being created; these being instance variables introduced by MM 2.1b5 and missing from MM 2.0.13 instance of the MailList class which is what is being dealt with at the time the update is being done. Adding the following definition to the TopicMgr and Bouncer class definitions seem to clear the problem although whether this is the best log-tem solution is questionable: InitTempVars = InitVars ---------------------------------------------------------------------- >Comment By: Barry A. Warsaw (bwarsaw) Date: 2002-12-23 22:14 Message: Logged In: YES user_id=12800 I'm closing this one since I've added language to the UPGRADING file alerting people to this (although I suspect the Pinball Machine Rule will apply). Thanks for figuring this one out. ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2002-12-11 07:19 Message: Logged In: YES user_id=75166 patch revised for MM 2.1b6 and better documented internally ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2002-12-10 09:19 Message: Logged In: YES user_id=75166 The problem is a by product of the 413752 (coerce to plaintext) patch for MM 2.0.13 (mailman-2.0.13-plaintext- 0.17.patch) which had been applied to the existing system Patch 413752 for MM 2.0.13 changes Version.py as follows: # config.db schema version number -DATA_FILE_VERSION = 21 +DATA_FILE_VERSION = (21, 'plaintext_patch') In MM 2.1b5 Version.py DATA_FILE_VERSION = 88 In the CheckVersion member function of the MailList class the following comparison succeeds, i.e. the existing data structure is seen as being a later revision than MM 2.1b5, when patch 413752 has been applied: if self.data_version >= mm_cfg.DATA_FILE_VERSION: and the CheckVersion function returns without calling the InitVars function to preset the instance variables to the defaults before loading the pickled data values for an existing list. Changing the comparisom to this solves the problem: if (type(self.data_version) is type (mm_cfg.DATA_FILE_VERSION) and \ self.data_version >= mm_cfg.DATA_FILE_VERSION) or \ (type(self.data_version) is type(()) and \ self.data_version[0] >= mm_cfg.DATA_FILE_VERSION): ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2002-12-10 08:13 Message: Logged In: YES user_id=75166 I was wrong about my hack working because on using the web admin GUI to update lists I got the error feedback given below. The problem seems to be more deep seated in that the InitVars function of the MailList class does not seem to get called to initialse the MailList instance variables when loading an existing list via the __init__ function but only through the Create member function called from newlist and cgi create.py. At first blush I would think that MailList InitVars function should be called from the class' __init__ function before loading an existing instance's data into the instance variables; but with three functions initialisation functions, __init__, InitTempVars and InitVars, I'm getting confused as to which are supposed to do what and when. Bug in Mailman version 2.1b5 We're sorry, we hit a bug! If you would like to help us identify the problem, please email a copy of this page to the webmaster for this site with a description of what happened. Thanks! Traceback: Traceback (most recent call last): File "/mailman/run/scripts/driver", line 87, in run_main main() File "/mailman/run/Mailman/Cgi/admin.py", line 76, in main i18n.set_language(mlist.preferred_language) File "/mailman/run/Mailman/MailList.py", line 130, in __getattr__ raise AttributeError, name AttributeError: preferred_language ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=651406&group_i…

1 0

[ mailman-Bugs-655144 ] Setting language through config_list
by noreply＠sourceforge.net 24 Dec '02

24 Dec '02

Bugs item #655144, was opened at 2002-12-17 07:13 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=655144&group_i… Category: command line scripts Group: 2.1 beta >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: Martin v. Löwis (loewis) Assigned to: Nobody/Anonymous (nobody) Summary: Setting language through config_list Initial Comment: I tried changing a list's preferred_language through config_list, and got this traceback Traceback (most recent call last): File "config_list", line 336, in ? main() File "config_list", line 331, in main do_input(listname, infile, checkonly, verbose) File "config_list", line 283, in do_input gui._setValue(mlist, k, validval, fakedoc) File "/home/mailman/Mailman/Gui/Language.py", line 121, in _setValue doc.set_language(val) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=655144&group_i…

1 0

[ mailman-Patches-656097 ] fix for bug id 655144
by noreply＠sourceforge.net 24 Dec '02

24 Dec '02

Patches item #656097, was opened at 2002-12-18 22:07 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=656097&group_i… Category: command line scripts Group: Mailman 2.1 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Tokio Kikuchi (tkikuchi) Assigned to: Nobody/Anonymous (nobody) Summary: fix for bug id 655144 Initial Comment: Here is a quick hack for fixing bug id 655144 -- fail to set list preferred language through command line. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2002-12-18 22:09 Message: Logged In: YES user_id=67709 forget to check attach? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=656097&group_i…

1 0

[ mailman-Patches-656346 ] correct logging of pending requests
by noreply＠sourceforge.net 24 Dec '02

24 Dec '02

Patches item #656346, was opened at 2002-12-19 10:49 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=656346&group_i… Category: list administration Group: Mailman 2.1 >Status: Closed >Resolution: Rejected Priority: 5 Submitted By: Jost Krieger (jkrieger) Assigned to: Nobody/Anonymous (nobody) Summary: correct logging of pending requests Initial Comment: I have no idea what the previous code was supposed to do. The new version logs what I think it should log (for me). --- Mailman/MailList.py.ORIG Wed Nov 27 12:01:18 2002 +++ Mailman/MailList.py Wed Nov 27 12:01:44 2002 @@ -826,7 +826,7 @@ if recipient <> email: who = "%s (%s)" % (email, recipient.split('@')[0]) else: - who = name + who = "%s (%s)" % (email, name) syslog('subscribe', '%s: pending %s %s', self.internal_name(), who, by) raise Errors.MMSubscribeNeedsConfirmation ---------------------------------------------------------------------- >Comment By: Barry A. Warsaw (bwarsaw) Date: 2002-12-23 22:03 Message: Logged In: YES user_id=12800 I believe this is outdated by changes already in MM2.1b6+ ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=656346&group_i…

1 0

[ mailman-Patches-655214 ] Fix archiving
by noreply＠sourceforge.net 24 Dec '02

24 Dec '02

Patches item #655214, was opened at 2002-12-17 09:49 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=655214&group_i… Category: Pipermail Group: Mailman 2.1 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Martin v. Löwis (loewis) Assigned to: Nobody/Anonymous (nobody) Summary: Fix archiving Initial Comment: This patch restores MIME charset capabilities for article archiving in CVS mailman. It: - removes the .charset attribute from articles; all articles are encoded in the list's charset, - decodes subject and author to Unicode; if this fails, no decoding (not even MIME) is done to subject and author, - MIME-decodes the body in the constructor using get_payload, removes the hand-crafted qp decoding from _get_body, - Unicode-decodes the body in the constructor if the body's charset differs from the list's charset, - fixes processbody_URLquote to always return byte strings (by escaping the URL also); comparing the old and the new string is no longer possible since the old string is Unicode and the new string is a list-encoded byte string. - changes text archiving to have the archives in the list's encoding, with unsupported characters 'replace'd - Fixes a bug in the scrubber, where a content-transfer-encoding might have survived flattening of the message. With these changes, I can process the playground archives correctly, to get mojibake-free pages. ---------------------------------------------------------------------- >Comment By: Barry A. Warsaw (bwarsaw) Date: 2002-12-23 21:54 Message: Logged In: YES user_id=12800 I like this patch and will now apply it. Much better than my feeble attempt. ;) I was wondering why the 2nd letter in Martin's last name was coming out as a Russian character instead of o-umlaut in 2002-December/000056.html and was going to complain --- until I realized that Python 2.1.3 doesn't have the windows-1252 codec! I re-installed my test list with Python 2.2.2 and everything looked great. tkikuchi's mod is correct for PYthon 2.1.3 support, so the combination is what I'm checking in. Thank! ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2002-12-19 19:45 Message: Logged In: YES user_id=67709 Thanks. It looks like working for me (Japanese), except there was a typo: if isinstance(body, unicode): should be if isinstance(body, types.UnicodeType): ---------------------------------------------------------------------- Comment By: Martin v. Löwis (loewis) Date: 2002-12-19 01:55 Message: Logged In: YES user_id=21627 Oops, attached. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2002-12-18 22:13 Message: Logged In: YES user_id=67709 Hi, Martin, Haven't you forget to attach file? I am interested in reviewing your patch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=655214&group_i…

1 0

[ mailman-Patches-657951 ] Generate RSS summary in archives
by noreply＠sourceforge.net 23 Dec '02

23 Dec '02

Patches item #657951, was opened at 2002-12-23 14:17 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=657951&group_i… Category: Pipermail Group: Mailman 2.2 / 3.0 Status: Open Resolution: None Priority: 5 Submitted By: A.M. Kuchling (akuchling) Assigned to: Nobody/Anonymous (nobody) Summary: Generate RSS summary in archives Initial Comment: Here's a first-draft patch. Things that need fixing: * The generated RSS feed needs to be validated. (It passed the W3C's RDF validator, but RSS validators still need to be checked.) * The date should be given in YYYY-MM-DD format, which requires parsing the .fromdate attribute. * How do I get the URL for an archived message? The generated RSS currently just uses the filename, which is wrong. How do I get at the PUBLIC_ARCHIVE_URL setting? * Getting the most recent N postings is inefficient; the code loops through all of the archived messages and takes the last N of them. We could add .last() and .prev() methods to the Database class, but that's more ambitious for 2.1beta than I like. (Would be nice to get this into 2.1final...) * The list index page should have a LINK element pointing to the RSS file. Please make any comments you have, and I'll rework the patch accordingly. ---------------------------------------------------------------------- >Comment By: A.M. Kuchling (akuchling) Date: 2002-12-23 15:42 Message: Logged In: YES user_id=11375 Updated patch: * Dates are now rendered as ISO-8601 (date only, not the time of the message) * By hard-wiring 2002-December, I got the RSS to validate using Mark Pilgrim's validator. ---------------------------------------------------------------------- Comment By: captain larry (captainlarry) Date: 2002-12-23 14:36 Message: Logged In: YES user_id=147905 Just voting for support here. This is *great* thanks for the patch and I hope the maintainers include it as soon as it's appropriate :) Adam. ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2002-12-23 14:27 Message: Logged In: YES user_id=12800 Deferring until post-2.1 ---------------------------------------------------------------------- Comment By: A.M. Kuchling (akuchling) Date: 2002-12-23 14:21 Message: Logged In: YES user_id=11375 Argh; SF choked on the file upload. Attaching the patch again... ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=657951&group_i…

1 0

[ mailman-Patches-645297 ] Add PGP support
by noreply＠sourceforge.net 23 Dec '02

23 Dec '02

Patches item #645297, was opened at 2002-11-28 14:54 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=645297&group_i… Category: None Group: Mailman 2.2 / 3.0 Status: Open Resolution: None Priority: 5 Submitted By: Ben Laurie (benl) Assigned to: Nobody/Anonymous (nobody) Summary: Add PGP support Initial Comment: Support PGP encrypted lists using GnuPG. ---------------------------------------------------------------------- Comment By: captain larry (captainlarry) Date: 2002-12-23 19:37 Message: Logged In: YES user_id=147905 Adding a vote of support for this patch. Please add it as soon as it's appropriate! I've been waiting a long time for this functionality and I'd hate to see the patch bitrot. :-) Adam. ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2002-12-12 03:56 Message: Logged In: YES user_id=12800 I have to defer this patch until after MM2.1 since we're about ready for the first release candidate. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=645297&group_i…

1 0

[ mailman-Patches-657951 ] Generate RSS summary in archives
by noreply＠sourceforge.net 23 Dec '02

23 Dec '02

Patches item #657951, was opened at 2002-12-23 19:17 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=657951&group_i… Category: Pipermail Group: Mailman 2.2 / 3.0 Status: Open Resolution: None Priority: 5 Submitted By: A.M. Kuchling (akuchling) Assigned to: Nobody/Anonymous (nobody) Summary: Generate RSS summary in archives Initial Comment: Here's a first-draft patch. Things that need fixing: * The generated RSS feed needs to be validated. (It passed the W3C's RDF validator, but RSS validators still need to be checked.) * The date should be given in YYYY-MM-DD format, which requires parsing the .fromdate attribute. * How do I get the URL for an archived message? The generated RSS currently just uses the filename, which is wrong. How do I get at the PUBLIC_ARCHIVE_URL setting? * Getting the most recent N postings is inefficient; the code loops through all of the archived messages and takes the last N of them. We could add .last() and .prev() methods to the Database class, but that's more ambitious for 2.1beta than I like. (Would be nice to get this into 2.1final...) * The list index page should have a LINK element pointing to the RSS file. Please make any comments you have, and I'll rework the patch accordingly. ---------------------------------------------------------------------- Comment By: captain larry (captainlarry) Date: 2002-12-23 19:36 Message: Logged In: YES user_id=147905 Just voting for support here. This is *great* thanks for the patch and I hope the maintainers include it as soon as it's appropriate :) Adam. ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2002-12-23 19:27 Message: Logged In: YES user_id=12800 Deferring until post-2.1 ---------------------------------------------------------------------- Comment By: A.M. Kuchling (akuchling) Date: 2002-12-23 19:21 Message: Logged In: YES user_id=11375 Argh; SF choked on the file upload. Attaching the patch again... ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=657951&group_i…

1 0